[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: Locking: regarding fsfs

From: Ben Collins-Sussman <sussman_at_red-bean.com>
Date: 2004-11-20 20:59:09 CET

On Nov 20, 2004, at 1:39 PM, Branko Čibej wrote:
>
> What about skel-tests, then? They're a BDB implementation detail.
>

Hm, yah, so maybe that README is just out-of-date. But notice they're
in a separate file.

>
>
> We only have tests for libsvn_fs_base, which is pretty BDB-centric. We
> really should refactor those tests.
>

If you look through fs-tests.c, there's only 3 calls to svn_fs__* in 42
tests. (And they're svn_fs__id_t's). Everything else is public fs API
calls. I think we're just a tiny skip away from making fs-tests.c
generic for any fs back-end. I like the idea of adding an
"--backend=fsfs" switch or something.

(And meanwhile, bdb- or fsfs- specific tests can live in separate
collections, like skel-test.c)

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Received on Sat Nov 20 21:01:01 2004

This is an archived mail posted to the Subversion Dev mailing list.