Re: Locking: regarding fsfs

Ben Collins-Sussman wrote:

> If you look through fs-tests.c, there's only 3 calls to svn_fs__* in
> 42 tests. (And they're svn_fs__id_t's). Everything else is public fs
> API calls. I think we're just a tiny skip away from making fs-tests.c
> generic for any fs back-end. I like the idea of adding an
> "--backend=fsfs" switch or something.

"--fs-type", like the cmdline tests. This is more or less what I had in
mind, yes. Sorry if I wasn't clear enough. The unit test infrastructure
might need some work to get this through, and run_fs_tests.py should
call fs-tests twice, once for BDB and once for FSFS.

> (And meanwhile, bdb- or fsfs- specific tests can live in separate
> collections, like skel-test.c)

Right. I still think we should split them into the correct directories,
though; libsvn_fs, libsvn_fs_base and libsvn_fs_fs. There's

-- Brane

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Received on Sun Nov 21 02:37:16 2004