[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: svn commit: r11783 - trunk/subversion/svnserve

From: Peter N. Lundblad <peter_at_famlundblad.se>
Date: 2004-11-11 20:56:55 CET

On Wed, 10 Nov 2004, Greg Hudson wrote:

> On Tue, 2004-11-09 at 14:29, Peter N. Lundblad wrote:
> There's not much point in checking the return value of fprintf() when
> writing an error message to stderr prior to exiting. What are you going
> to do if it fails?
>
Print an error message to stderr:-) Ofcoruse, you're right. I was talking
about the printf statements in general, but I see that wasn't clear in
that context. Maybe there are no such in svnserve, isnce they are either
help or error messages. Sorry for the confusion.

> > I don't know why apr_socket_listen isn't checked.
>
> listen() can't fail if you pass it a valid socket.
>
> Or so I thought, anyway. My man page says that listen() can return
> EADDRINUSE, but I would think that's more of a bind() error.
>
If I remember POSIX correctly, an implementation is allowed to add other
error conditions. Also, I don't know about Windows. Ignore the error is
just sloppy, I would say.

Regards,
//Peter

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Received on Thu Nov 11 21:48:15 2004

This is an archived mail posted to the Subversion Dev mailing list.