Re: [PATCH] Fix encoding bug of 'svnserve -h'

On Thu, 11 Nov 2004, Kobayashi Noritada wrote:

> Asian languages are sensitive to those bugs although they may make
> little difference for European languages.

Yes, but they make difference. едц aren't nice UTF-8-encoded on an
Iso-8859-1 display. So, you're not alone.

Index: subversion/svnserve/main.c
===================================================================
--- subversion/svnserve/main.c (revision 11818)
+++ subversion/svnserve/main.c (working copy)
@@ -137,16 +137,17 @@
 {
   apr_size_t i;

- puts("Usage: svnserve [options]\n"
- "\n"
- "Valid options:");
+ svn_error_clear (svn_cmdline_fprintf(stdout, pool,
+ "Usage: svnserve [options]\n"
+ "\n"
+ "Valid options:"));

We have svn_cmdline_fputs that you could use for consistency with other
code.

The rest looks good. Please fix that, test and I'm +1.

Thanks,
//Peter

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Received on Thu Nov 11 21:48:03 2004