Re: svn commit: r11783 - trunk/subversion/svnserve

Branko ÄŒibej <brane@xbc.nu> writes:

> lundblad@tigris.org wrote:
>
>> apr_socket_listen(sock, 7);
>>+
>>+ /* svn_cmdline_init() sets up the locale, but when we serve clients, we
>>+ always want the "C" locale. */
>>+ if (!setlocale (LC_ALL, "C"))

Yuck! You are forcing the user to use plain ASCII for the --root
path, and that's not really acceptable. On Unix systems setting
LC_MESSAGES is probably what you want, I don't know about Windows.

>>+ {
>>+ fprintf(stderr, "Can't set locale back to the \"C\" locale\n");
>>
>>
> This message should be marked for translation. :-)
> And I think the wording is a bit unfortunate; [l]users will keep
> asking us what this "C" locale is all about. Perhaps "can't turn off
> message translation", or something along those lines?

-- 
Philip Martin
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org