Re: svn commit: r11768 - trunk/subversion/tests/clients/cmdline

On 2004-11-08 09:02-0600, kfogel@collab.net wrote:
> jaa@tigris.org writes:
> > Log:
> > Fix the fixed size keyword test on win32 systems. Don't open a text
> > base file with binary flag.
> >
> > * subversion/tests/clients/cmdline/trans_tests.py
> > (keywords_from_birth): Don't use binary flag when opening text
> > base files.
>
> This was a bit surprising to me... Why wouldn't one open a text base
> file as binary in every case? What bad effect was it having?
>

I have the 'to be expected' keyword strings and keyword stubs written
as: '$URL:: ..... \n' and python writes them to the disk with "\r\n"
line endings on Windows. If I read those strings back to python on
text mode, the line ends are exactly '\n' (which will match my test
strings). If I read them as binary (rb), the string will contain
"\r\n" which won't match with '\n' (extra '\r'). The
fixed_keyword_test file doesn't use svn:eol-style=native, so the text
base is indeed in '\r\n' mode.

It is fun, isn't it?

BR, Jani

-- 
Jani Averbach
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org