[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: svn commit: r11768 - trunk/subversion/tests/clients/cmdline

From: <kfogel_at_collab.net>
Date: 2004-11-08 16:02:09 CET

jaa@tigris.org writes:
> Log:
> Fix the fixed size keyword test on win32 systems. Don't open a text
> base file with binary flag.
>
> * subversion/tests/clients/cmdline/trans_tests.py
> (keywords_from_birth): Don't use binary flag when opening text
> base files.

This was a bit surprising to me... Why wouldn't one open a text base
file as binary in every case? What bad effect was it having?

-Karl

> Modified: trunk/subversion/tests/clients/cmdline/trans_tests.py
> Url: http://svn.collab.net/viewcvs/svn/trunk/subversion/tests/clients/cmdline/trans_tests.py?view=diff&rev=11768&p1=trunk/subversion/tests/clients/cmdline/trans_tests.py&r1=11767&p2=trunk/subversion/tests/clients/cmdline/trans_tests.py&r2=11768
> ==============================================================================
> --- trunk/subversion/tests/clients/cmdline/trans_tests.py (original)
> +++ trunk/subversion/tests/clients/cmdline/trans_tests.py Sat Nov 6 16:12:36 2004
> @@ -343,7 +343,7 @@
> ]
>
> fp = open(os.path.join(wc_dir, '.svn', 'text-base',
> - 'fixed_length_keywords.svn-base'), 'rb')
> + 'fixed_length_keywords.svn-base'), 'r')
> actual_textbase_kw = fp.readlines()
> fp.close()
> check_keywords(actual_textbase_kw, kw_textbase, "text base")
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: svn-unsubscribe@subversion.tigris.org
> For additional commands, e-mail: svn-help@subversion.tigris.org

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Received on Mon Nov 8 17:57:15 2004

This is an archived mail posted to the Subversion Dev mailing list.