[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: svn commit: r11768 - trunk/subversion/tests/clients/cmdline

From: Branko Čibej <brane_at_xbc.nu>
Date: 2004-11-09 01:28:31 CET

Jani Averbach wrote:

>On 2004-11-08 09:02-0600, kfogel@collab.net wrote:
>
>
>>jaa@tigris.org writes:
>>
>>
>>>Log:
>>>Fix the fixed size keyword test on win32 systems. Don't open a text
>>>base file with binary flag.
>>>
>>>* subversion/tests/clients/cmdline/trans_tests.py
>>> (keywords_from_birth): Don't use binary flag when opening text
>>> base files.
>>>
>>>
>>This was a bit surprising to me... Why wouldn't one open a text base
>>file as binary in every case? What bad effect was it having?
>>
>>
>>
>
>I have the 'to be expected' keyword strings and keyword stubs written
>as: '$URL:: ..... \n' and python writes them to the disk with "\r\n"
>line endings on Windows.
>
How about _writing_ them in binary mode, and then opening the files "rb"
anyway? A lot cleaner, I think.

-- Brane

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Received on Tue Nov 9 01:28:30 2004

This is an archived mail posted to the Subversion Dev mailing list.