[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: svn commit: r11400 - trunk/subversion/libsvn_delta

From: <kfogel_at_collab.net>
Date: 2004-10-14 19:45:44 CEST

> > 1. Use conditional definition:
> > #ifndef MIN
> > #define MIN(a, b) ((a) < (b) ? (a) : (b))
> > #endif
> > And remove the #undef altogether.
>
> That's reasonable.
>
> > 2. Use SVN_MIN instead of TMP_MIN.
>
> Putting it in our "own" name space at least helps us keep track of it
> and makes it easier for other projects to avoid clashes with ours,
> even though it does not guarantee it.
>
> 3. Just undefine MIN before re-defining it:
>
> #undef MIN
> #define MIN ...
>
> I'm pretty confident that a compiler is not allowed to complain
> about undefining a symbol even if it was not already defined. And it
> guarantees that we get the definition that we want.

Okay, I've done it a different way in rCONFLICT... Uh, I mean, Mike's
done in r11404 exactly what I was about to do only he done it sooner.

-karl

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Received on Thu Oct 14 21:35:44 2004

This is an archived mail posted to the Subversion Dev mailing list.