[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: svn commit: r11233 - trunk/subversion/clients/cmdline

From: Peter N. Lundblad <peter_at_famlundblad.se>
Date: 2004-10-06 22:39:06 CEST

On Wed, 5 Oct 2004 kfogel@collab.net wrote:

> The way this doc string is written, it sounds like if ENCODING is
> null, use the native encoding no matter what the value of AS_TEXT!
>
> Also, the phrasing "use the native encoding" is ambiguous. Is it
> behaving exactly the same way as with ENCODING, except that it's using
> the native encoding? Or is eol-style treated differently when
> ENCODING is null?
>
HOpefully I've explained better in r11260. If not, feel free to improve
the docstring.

> Also, your log message didn't mention that you'd condensed to remove a
> variable ('new_propval' was folded out and 'propval' used instead, in
> two places). It might be good to prepare the reader by mentioning
> that, since it's independent of the goal of your change (I think). At
> first I got a bit confused by it, then I realized you were just
> cleaning out an unneeded tmp variable since you happened to be in the
> neighborhood.
>
Ooops. Missed that one. Fixed.

Regards,
//Peter

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Received on Wed Oct 6 22:24:36 2004

This is an archived mail posted to the Subversion Dev mailing list.