[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: svn commit: r11233 - trunk/subversion/clients/cmdline

From: <kfogel_at_collab.net>
Date: 2004-10-06 03:33:18 CEST

lundblad@tigris.org writes:
> --- trunk/subversion/clients/cmdline/cl.h (original)
> +++ trunk/subversion/clients/cmdline/cl.h Mon Oct 4 15:01:33 2004
> @@ -276,18 +276,24 @@
> CONFIG is a hash of svn_config_t * items keyed on a configuration
> category (SVN_CONFIG_CATEGORY_CONFIG et al), and may be NULL.
>
> + If AS_TEXT is true, convert CONTENTS to ENCODING and native eol-style before
> + editing and back to UTF-8/LF afterwards. If ENCODING is NULL, use the
> + native encoding.
> +
> Use POOL for all allocations. Use PREFIX as the prefix for the
> temporary file used by the editor.

The way this doc string is written, it sounds like if ENCODING is
null, use the native encoding no matter what the value of AS_TEXT!

Of course, you don't mean that -- if you did, there would be no need
for an AS_TEXT parameter at all :-).

Also, the phrasing "use the native encoding" is ambiguous. Is it
behaving exactly the same way as with ENCODING, except that it's using
the native encoding? Or is eol-style treated differently when
ENCODING is null?

Could you please rewrite to avoid all possible ambiguity here?

Also, your log message didn't mention that you'd condensed to remove a
variable ('new_propval' was folded out and 'propval' used instead, in
two places). It might be good to prepare the reader by mentioning
that, since it's independent of the goal of your change (I think). At
first I got a bit confused by it, then I realized you were just
cleaning out an unneeded tmp variable since you happened to be in the
neighborhood.

Best,
-Karl

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Received on Wed Oct 6 05:20:54 2004

This is an archived mail posted to the Subversion Dev mailing list.