[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Line-endings in libsvn_diff was Re: OS/2 port, working through the tests

From: Justin Erenkrantz <justin_at_erenkrantz.com>
Date: 2004-07-22 20:17:25 CEST

--On Wednesday, July 21, 2004 9:08 PM +1000 Brian Havard
<brianh@kheldar.apana.org.au> wrote:

> Hi all,
> I've got the current 1.1 code to build & run on OS/2 and thought it might
> be nice if it passed the test suit. I haven't built with BDB so I did a
> "make fsfscheck" and the first failures I hit were

Cool! Any patches needed for it to build?

> I found the first was a line end problem (OS/2 uses DOS style CR/LF) as
> making changes like the diff below makes the test pass. So which is wrong,
> the test or the library?

I think it's the test in this particular situation. I think all of the
'output' in the tests should be terminated with APR_EOL_STR as diff outputs
the line encoding of the host OS not what's in the file, IIRC.

Yet, if that's the case, I'm wondering how it passes on Win32 then as it
should have the same problem. Sander? -- justin

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Received on Thu Jul 22 20:17:54 2004

This is an archived mail posted to the Subversion Dev mailing list.