Re: Line-endings in libsvn_diff was Re: OS/2 port, working through the tests

On Thu, 22 Jul 2004 11:17:25 -0700, Justin Erenkrantz wrote:

>--On Wednesday, July 21, 2004 9:08 PM +1000 Brian Havard
><brianh@kheldar.apana.org.au> wrote:
>
>> Hi all,
>> I've got the current 1.1 code to build & run on OS/2 and thought it might
>> be nice if it passed the test suit. I haven't built with BDB so I did a
>> "make fsfscheck" and the first failures I hit were
>
>Cool! Any patches needed for it to build?

Yeah, I'll be submitting a few patches once I'm happy with it. I've still
got a few issues to resolve with the build system (I currently have to edit
the generated Makefiles to make it work). I've fixed a few things in APR
already.

>> I found the first was a line end problem (OS/2 uses DOS style CR/LF) as
>> making changes like the diff below makes the test pass. So which is wrong,
>> the test or the library?
>
>I think it's the test in this particular situation. I think all of the
>'output' in the tests should be terminated with APR_EOL_STR as diff outputs
>the line encoding of the host OS not what's in the file, IIRC.
>
>Yet, if that's the case, I'm wondering how it passes on Win32 then as it
>should have the same problem. Sander? -- justin

That's what I suspected but I also wondered how/if it passed on windows.

-- 
 ______________________________________________________________________________
 |  Brian Havard                 |  "He is not the messiah!                   |
 |  brianh@kheldar.apana.org.au  |  He's a very naughty boy!" - Life of Brian |
 ------------------------------------------------------------------------------
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org