[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

OS/2 port, working through the tests

From: Brian Havard <brianh_at_kheldar.apana.org.au>
Date: 2004-07-21 13:08:28 CEST

Hi all,
  I've got the current 1.1 code to build & run on OS/2 and thought it might
be nice if it passed the test suit. I haven't built with BDB so I did a
"make fsfscheck" and the first failures I hit were

svn: failed comparing 'foo2' and 'bar2'
FAIL: diff-diff3-test.exe 1: these dump core
svn: failed comparing 'foo4' and 'bar4'
FAIL: diff-diff3-test.exe 2: 2-way unified diff and trivial merge
svn: failed comparing 'foo15a' and 'bar15a'
[the rest pass]

I found the first was a line end problem (OS/2 uses DOS style CR/LF) as
making changes like the diff below makes the test pass. So which is wrong,
the test or the library?

Index: diff-diff3-test.c
===================================================================
--- diff-diff3-test.c (revision 10374)
+++ diff-diff3-test.c (working copy)
@@ -376,9 +376,9 @@
                          "--- foo2" APR_EOL_STR
                          "+++ bar2" APR_EOL_STR
                          "@@ -1,3 +0,0 @@" APR_EOL_STR
- "-Aa\n"
- "-Bb\n"
- "-Cc\n",
+ "-Aa" APR_EOL_STR
+ "-Bb" APR_EOL_STR
+ "-Cc" APR_EOL_STR,
                          pool));
 
   SVN_ERR (two_way_diff ("foo3", "bar3",

-- 
 ______________________________________________________________________________
 |  Brian Havard                 |  "He is not the messiah!                   |
 |  brianh@kheldar.apana.org.au  |  He's a very naughty boy!" - Life of Brian |
 ------------------------------------------------------------------------------
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Received on Wed Jul 21 13:08:48 2004

This is an archived mail posted to the Subversion Dev mailing list.