Re: svn commit: r9806 - in trunk/subversion: include libsvn_subr

Peter N. Lundblad wrote:

>>No, because apr_get_os_error() doesn't use errno on Win32.
>>
>>
>So it uses GetLastError() then? Wouldn't a failed fputs on Windows also
>set GetLastError()? But that might be relying on the implementation
>internals?
>
>
Very much so, I'm afraid.

>Maybe it would be better to use plain errno? But I'd like not to use
>strerror directly.
>
>
You don't have to. Look at apr_errno.h: you'll notice that the core
posix-like codes (APR_EACCES, APR_ENOSPC, etc.) are mapped to the errono
values on all platforms. The Windows C runtime does use a number of
these, so the value of errno is always a valid APR error code.

>What I'd like is something more than the generic write error, but if it is
>difficult on non-POSIX systems, I'll just return the generic one and go
>on.
>
>
I'd suggest using plain errno as an APR error code. we can test what
happens on Windows.

-- Brane

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Received on Sat May 22 02:25:06 2004