[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: [PATCH] Eliminate some message fragments for I18N

From: Branko Čibej <brane_at_xbc.nu>
Date: 2004-05-13 00:31:59 CEST

Peter N. Lundblad wrote:

>Message fragments are evil for translators, so we need to get rid of them.
>This patch does this for some that I found. Some were already _()-marked,
>others contain revision numbers and aren't marked yet. I do this in
>preparation for marking them, but I do it in separate steps, so that it'll
>be easier to review. This patch includes small restructurings of code, so
>we have to be more careful than with just _()-marking.
>Removed string composition in preparation for more _() markers.
>* subversion/clients/cmdline/notify.c (notify):
> Remove sentence fragments as arguments in conditionals to printf, factoring
> out the condition into an if statement outside the printf.
>* subversion/libsvn_wc/adm_ops.c (revert_error):
> Remove, factoring out it into its callers.
>* subversion/libsvn_wc/props.c (validate_prop_against_node_kind):
> Restructure so that each error message is complete.
These look good to me. +1, assuming tests pass.

-- Brane

To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Received on Thu May 13 00:33:01 2004

This is an archived mail posted to the Subversion Dev mailing list.

This site is subject to the Apache Privacy Policy and the Apache Public Forum Archive Policy.