[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: [PATCH] Re: replacing SVN_REVNUM_T_FMT for translation

From: Branko Čibej <brane_at_xbc.nu>
Date: 2004-05-13 00:36:11 CEST

Peter N. Lundblad wrote:

>On Tue, 11 May 2004, Peter N. Lundblad wrote:
>>On Mon, 10 May 2004 kfogel@collab.net wrote:
>>in the patch, but anyway, here it is. I've eliminated SVN_REVNUM_T_FMT in
>>all .c files and replaced with ld.
>When doing this, I found some instances of plain sprintf into a
>stack-allocated fixed-size buffer. Are they worth eliminating as per
>HACKING? The buffer is 20 chars long, and I think that would be too short
>if long int happens to be 64 bits on a platform.
I'll note that most of our sprintfs are 100% safe. I see no reason to
eliminate those, and add more allocations or gods forbid new pool
arguments where there weren't any.

-- Brane

To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Received on Thu May 13 00:36:34 2004

This is an archived mail posted to the Subversion Dev mailing list.

This site is subject to the Apache Privacy Policy and the Apache Public Forum Archive Policy.