Peter N. Lundblad wrote:
>I'd like to work on the remaining localization issues that have been
>discussed on the list before. But I'd like to make sure I understand what
>the consensus form these discussions are. I'll start with two of the
>First we have the encoding mess... We've converted the .po files to UTF-8
>and are going to make _() and friends return UTF-8 strings. So now we need
>to convert everything that produces output in the cmdline client to
>convert from UTF8 to the locale encoding. I have two proposals for this:
>- Either we make something like convert_string_for_output in
>libsvn_subr/error.c a public (or internal) function and use it for the
>format string in every printf/puts/fprintf/... call.
we already have suc a function. It's called
svn_cmdline_cstring_from_utf8 (or svn_cmdline_cstring_from_utf8_fuzzy,
if you don't need strict conversion).
But I notice that since the last time I checked all the code, some new
printf's have cropped up which don't take care of the conversion... Aaargh!
>Then we have the SVN_REVNUM_T_FMT matter. I think the consensus was to
>some function svn_revnum_to_string(revnum, pool) function and use it
>everywhere, deprecating SVN_REVNUM_T_FMT.
I wouldn't deprecate SVN_REVNUM_T_FMT. After all, it gets used in this
>Woluld anyone objet to adding
>this function to svn_types.h. IMO this shouldn't be a macro, since it is
>used in output and not performance critical.
It doesn't matter a bit whether it's a function or a macro, all it does
is call apr_psprintf...
I'm not sure this goes into svn_types.h, though. I'd suggest
svn_cmdline.h, and call the functino svn_cmdline_cstring_from_revnum.
Also note that this function should return the revnum either in UTF-8,
or in the output encoding (which is _not_ the same as the native
encoding, thanks be to Windows...).
> Then we can localize the
>strings with revision numers.
>If anyone is working on one of these (Erik?), please tell me. Otherwise
>I'll start tonight.
To unsubscribe, e-mail: firstname.lastname@example.org
For additional commands, e-mail: email@example.com
Received on Wed May 5 18:19:44 2004