[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: [PATCH] Phase 2 of Keywords as Hash

From: John Peacock <jpeacock_at_rowman.com>
Date: 2004-04-23 21:12:36 CEST

Garrett Rooney wrote:

> At first glance this stuff seems good, I'm just curious why you're
> typedefing your own name for apr_hash_t, since I don't recall any of the
> other places in the codebase doing that. To me, the special typename
> implies that it does somethign special, except it doesn't, it's just a
> normal apr_hash_t...

I'd be perfectly happy to regenerate sans the special typedef. In the earlier
phases of this patch, it was actually replacing the svn_subst_keywords_t struct,
which of course wasn't good for API compatibility.


John Peacock
Director of Information Research and Technology
Rowman & Littlefield Publishing Group
4501 Forbes Boulevard
Suite H
Lanham, MD  20706
301-459-3366 x.5010
fax 301-429-5748
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Received on Fri Apr 23 21:12:33 2004

This is an archived mail posted to the Subversion Dev mailing list.

This site is subject to the Apache Privacy Policy and the Apache Public Forum Archive Policy.