[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: [PATCH] Phase 2 of Keywords as Hash

From: Garrett Rooney <rooneg_at_electricjellyfish.net>
Date: 2004-04-23 21:22:41 CEST

John Peacock wrote:

> Garrett Rooney wrote:
>
>> At first glance this stuff seems good, I'm just curious why you're
>> typedefing your own name for apr_hash_t, since I don't recall any of
>> the other places in the codebase doing that. To me, the special
>> typename implies that it does somethign special, except it doesn't,
>> it's just a normal apr_hash_t...
>
>
> I'd be perfectly happy to regenerate sans the special typedef. In the
> earlier phases of this patch, it was actually replacing the
> svn_subst_keywords_t struct, which of course wasn't good for API
> compatibility.

Yeah, I think that would be better. No promise when I'll get a chance
to look at this, as I'm short on time lately, but I am paying attention,
and I do think this stuff is worthwhile, at least in that it gets us
closer to doing some of the more interesting things with properties that
I'm hoping for in the future.

-garrett

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Received on Fri Apr 23 21:23:06 2004

This is an archived mail posted to the Subversion Dev mailing list.

This site is subject to the Apache Privacy Policy and the Apache Public Forum Archive Policy.