[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: [PATCH] Phase 2 of Keywords as Hash

From: Garrett Rooney <rooneg_at_electricjellyfish.net>
Date: 2004-04-23 20:36:51 CEST

John Peacock wrote:

> And here is the second part of the Keywords as Hash patch, making all
> other Subversion libraries use the new libsvn_subst keyhash functions.
> No public API interface is touched and all tests pass.
> Just to restate the issues:
> 1) The existing keywords (typedef struct) is resistent to future expansion
> 2) plasma wrote a new implementation using hashes and a printf-like
> formatting
> 3) I brought that up to speed with the current code base, and
> additionally wrote API compatibility layers so that this could be
> considered for 1.1.0
> 4) These two patches do not include any new behavior, but are merely
> precursors to later keyword extensions
> See Issue 890 for further details (including links to previous list
> discussion). Log entry inline and patch attached.

At first glance this stuff seems good, I'm just curious why you're
typedefing your own name for apr_hash_t, since I don't recall any of the
other places in the codebase doing that. To me, the special typename
implies that it does somethign special, except it doesn't, it's just a
normal apr_hash_t...


To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Received on Fri Apr 23 20:37:06 2004

This is an archived mail posted to the Subversion Dev mailing list.

This site is subject to the Apache Privacy Policy and the Apache Public Forum Archive Policy.