On Friday 16 April 2004 06:24, S.Ramaswamy wrote:
> Log Message:
> Fix Issue #1777: 'svn blame' should default to the working revision,
> when no revision is specified.
>
> * subversion/clients/cmdline/blame-cmd.c
> (svn_cl__blame) : Set opt_state->end_revision.kind
> to svn_opt_revision_base,to ensure 'svn blame' defaults to base
> revision.
>
>
> Index: subversion/clients/cmdline/blame-cmd.c
> ===================================================================
> -- subversion/clients/cmdline/blame-cmd.c (revision 9374)
> +++ subversion/clients/cmdline/blame-cmd.c (working copy)
> @@ -108,7 +108,7 @@
> opt_state->start_revision.value.number = 1;
> }
> else
> - opt_state->end_revision.kind = svn_opt_revision_head;
> + opt_state->end_revision.kind = svn_opt_revision_base;
> }
>
> if (opt_state->start_revision.kind == svn_opt_revision_unspecified)
Small problem here. This breaks using a URL without specifying a revision.
With your patch I get the following when trying to use a URL instead of a
working copy path:
:: svn blame file://`pwd`/repo/A
subversion/libsvn_wc/lock.c:373: (apr_err=155007)
svn: 'file:///home/jszakmeister/projects/tmp/repo' is not a working copy
I think the best solution here would be to let svn_client_blame() resolve the
start and end revision if it's unspecified. This changes the API a little,
so the earliest it could make it into a release would be 1.1 (which is where
the issue put it anyways). Would you mind taking another stab at this but
fixing svn_client_blame() instead?
-John
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Received on Fri Apr 16 14:16:07 2004