Re: [PATCH] Do not use gettextize and i18n round 2 Re: I18n: The gettext proposal

> --- subversion/libsvn_subr/opt.c (revision 9230)
> +++ subversion/libsvn_subr/opt.c (working copy)
> @@ -36,6 +36,8 @@
> #include "svn_utf.h"
> #include "svn_time.h"
>
> +#include "svn_private_config.h"
> +
> 

Autoconf's "config.h" is supposed to be included *before* any other
header. This is how every other package (except subversion) does it.
It's even recommended in the autoconf manual:

> The package should `#include' the configuration header file before
> any other header files, to prevent inconsistencies in declarations (for
> example, if it redefines `const'). Use `#include <config.h>' instead
> of `#include "config.h"', and pass the C compiler a `-I.' option (or
> `-I..'; whichever directory contains `config.h'). That way, even if
> the source directory is configured itself (perhaps to make a
> distribution), other build directories can also be configured without
> finding the `config.h' from the source directory.

Some macros even depend of defining things before system include headers
too, e.g. the ones providing large file (>2Gb) support on Linux.

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Received on Wed Mar 31 05:12:09 2004