On Mon, 2004-03-29 at 06:05, Juanma Barranquero wrote:
> Greg Hudson <ghudson@MIT.EDU> wrote:
>
> > I'd say the best behavior would be to ensure at commit time that there
> > is a newline at the end of the log message
>
> Uh?
My reasoning is that it's more useful to say "a log message is some
lines of UTF-8 text, each terminated by a newline" than it is to just
say "a log message is some UTF-8 text."
> > and to only put an extra
> > newline at the end of the message in "svn log" if there isn't one
> > already there.
>
> That's cool.
Since CMike didn't like this part of the idea, I'll elaborate. If the
log message doesn't fit into our "lines of text" model, we should
massage it until it does. It's not exceptionally important that "svn
log" convey to us precisely what's in the svn:log property; we have svn
propget for that.
> When I was writing my hook I posted a message about whether was kosher
> or not to modify svn:log in a pre-commit hook (as there's a big "NOTE:
> THE HOOK PROGRAM MUST NOT MODIFY THE TXN" in pre-commit.tmpl).
That's purely so you don't mess up the working copy which performed the
commit. Since the working copy keeps no state about revision
properties, I think it should be just fine to add a note that it's okay
to set them in the pre-commit hook.
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Received on Mon Mar 29 13:24:07 2004