Re: [PATCH][repost] Don't add extra blank line to log messages

On Sat, 27 Mar 2004 23:06:12 -0500
Greg Hudson <ghudson@MIT.EDU> wrote:

> I'd say the best behavior would be to ensure at commit time that there
> is a newline at the end of the log message

Uh?

I wrote a pre-commit hook with the exact goal of removing the \n at the
end of the log property, because I hate it...

> and to only put an extra
> newline at the end of the message in "svn log" if there isn't one
> already there.

That's cool.

Related to this issue:

When I was writing my hook I posted a message about whether was kosher
or not to modify svn:log in a pre-commit hook (as there's a big "NOTE:
THE HOOK PROGRAM MUST NOT MODIFY THE TXN" in pre-commit.tmpl).

Someone (I think it was Karl) said that it was probably OK and that the
pre-commit.tmpl comment could be changed to reflect that.

Now I'm even depending on svn:author being changeable in pre-commit. Why?
Because my setup is SSL-only access, with

  SSLOptions +StrictRequire +FakeBasicAuth
  SSLVerifyClient require
  SSLVerifyDepth 1

(I don't want anonymous access,) so commits have author strings like:

  /C=ES/L=Madrid/O=MyCompany/OU=MyDepartment/CN=Juanma Barranquero

which in logs and ViewCVS is, how to say... unwieldy? My hook translates
them into our internal usernames, in this case "jbarranquero". Works
like a charm.

Understandably (I hope :) I'm now still more eager than ever to see
documented the fact that revision properties are changeable in
pre-commit. I could do a patch for subversion/libsvn_repos/repos.c to
adapt the comment, but I'm not sure if there's an agreement on that
issue or not.

                                                                Juanma

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Received on Mon Mar 29 13:06:13 2004