Re: [PATCH][repost] Don't add extra blank line to log messages

On Mon, 29 Mar 2004 06:23:41 -0500
Greg Hudson <ghudson@MIT.EDU> wrote:

> My reasoning is that it's more useful to say "a log message is some
> lines of UTF-8 text, each terminated by a newline" than it is to just
> say "a log message is some UTF-8 text."

My reasoning was just the contrary: a log message is arbitrary utf-8
data. Whether that data is composed of lines or not is entirely up to
the commiter (user, program, whatever).

> Since CMike didn't like this part of the idea, I'll elaborate. If the
> log message doesn't fit into our "lines of text" model, we should
> massage it until it does. It's not exceptionally important that "svn
> log" convey to us precisely what's in the svn:log property; we have svn
> propget for that.

Hmm... I agree with you here, so I must be wrong on the first paragraph...
:(

My problem with the finishing \n in svn:log was aesthetic: I didn't like
to have svn log output with both

  whatever
  ---------------------

and

  whatever

  ---------------------

On second thought, I think you're right: the svn:log should be
considered lines, and svn log should make an effort to show it right.
The property is not called "svn:log" by accident, after all. It is
entirely reasonable to assume things about its contents. And svn log
(with no --xml) is intended for human consumption, so it should help
readability.

> Since the working copy keeps no state about revision
> properties, I think it should be just fine to add a note that it's okay
> to set them in the pre-commit hook.

Glad to hear.

                                                                Juanma

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Received on Mon Mar 29 14:24:28 2004