Is it our intention that these new functions
svn_wc_adm_open_depth
svn_wc_adm_probe_try_depth
svn_wc_adm_probe_open_depth
supersede their non-depth predecessors, and that (eventually) all
callers of the predecessors be converted to use the depth versions? I
would think so, but just want to make sure here first.
If so, it's time to mark the predecessors
svn_wc_adm_open
svn_wc_adm_probe_try
svn_wc_adm_probe_open
as 'deprecated'. This should be pretty simple: just make a special
'deprecated' marker that's easy to grep for, and open a single new
issue in the 2.0 milestone:
"Remove deprecated 1.x interfaces."
That issue will give instructions to grep for the special marker. It
doesn't really matter whether we convert all the predecessors now, or
just make a note in the deprecated function's doc string that it needs
to be done before removing the function. (I'd prefer to do it now, if
it's not a big task, though, to avoid having bad examples in our
code.)
I can take care of all this; I just want to make sure it's what we
intend.
-Karl
djh@tigris.org writes:
> Log:
> Fix issue #1680: Don't lock entire tree in svn status --non-recursive
>
> Patch by Jon Foster, approved by Philip Martin.
>
> * svn_wc.h
> (svn_wc_adm_open_depth, svn_wc_adm_probe_open_depth,
> svn_wc_adm_probe_try_depth): New functions.
> (svn_wc_adm_open, svn_wc_adm_probe_open, svn_wc_adm_probe_try):
> Changed comments.
>
> * libsvn_wc/lock.c
> (do_open): Replace tree_lock parameter with depth, and use it.
> (svn_wc__adm_pre_open): Fixup call to do_open.
> (svn_wc_adm_open_depth): New function.
> (svn_wc_adm_open): Reimplement as trivial wrapper.
> (svn_wc_adm_probe_open_depth): New function.
> (svn_wc_adm_probe_open): Reimplement as trivial wrapper.
> (svn_wc_adm_probe_try_depth): New function.
> (svn_wc_adm_probe_try): Reimplement as trivial wrapper.
>
> * libsvn_client/status.c
> (svn_client_status): Use svn_wc_adm_probe_open_depth to avoid excessive
> recursion if --non-recursive.
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Received on Mon Mar 8 17:51:51 2004