[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: The new svn_wc_adm_*_depth functions.

From: D.J. Heap <dj_at_shadyvale.net>
Date: 2004-03-08 19:36:24 CET

kfogel@collab.net wrote:
> Is it our intention that these new functions
>
> svn_wc_adm_open_depth
> svn_wc_adm_probe_try_depth
> svn_wc_adm_probe_open_depth
>
> supersede their non-depth predecessors, and that (eventually) all
> callers of the predecessors be converted to use the depth versions? I
> would think so, but just want to make sure here first.

I believe so, based on past discussions and the need they address.

>
> If so, it's time to mark the predecessors
>
> svn_wc_adm_open
> svn_wc_adm_probe_try
> svn_wc_adm_probe_open
>
> as 'deprecated'. This should be pretty simple: just make a special
> 'deprecated' marker that's easy to grep for, and open a single new
> issue in the 2.0 milestone:
>
> "Remove deprecated 1.x interfaces."
>
> That issue will give instructions to grep for the special marker. It
> doesn't really matter whether we convert all the predecessors now, or
> just make a note in the deprecated function's doc string that it needs
> to be done before removing the function. (I'd prefer to do it now, if
> it's not a big task, though, to avoid having bad examples in our
> code.)
>
> I can take care of all this; I just want to make sure it's what we
> intend.
>
> -Karl

I can do this and submit a patch tonight or tomorrow if it's not
time-critical, which I wouldn't think it would be. Is there a standard
'deprecated' marker already? I seem to recall a similar discussion, but
I can't find it and don't see anything in HACKING.

DJ

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Received on Mon Mar 8 19:36:49 2004

This is an archived mail posted to the Subversion Dev mailing list.

This site is subject to the Apache Privacy Policy and the Apache Public Forum Archive Policy.