[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: PATCH: Convert text appropriately for console output and input

From: Branko Čibej <brane_at_xbc.nu>
Date: 2003-12-08 20:06:18 CET

Julian Foad wrote:

> Branko Čibej wrote:
>> Julian Foad wrote:
>>> Does this look right?
>> Yes, but...
>>> -/* ### todo: This function doesn't really belong in this header, but
>>> - it didn't seem worthwhile to create a new header just for one
>>> - function, especially since this should probably move to APR as
>>> - apr_cmdline_init() or whatever anyway. There's nothing
>>> - svn-specific in its code, other than SVN_WIN32, which obviously APR
>>> - has its own way of dealing with. Thoughts? (Brane?) */
>>> -/* ### Well, it's not one function any more, so it now has its own
>>> - header. Besides, everything here is svn-specific. --brane */
>>> +/* ### todo: This function should perhaps move to APR as
>>> + apr_cmdline_init() or whatever. */
>> ...this bit does not. The point of my reply to Karl's comment was that
>> this initializatino does _not_ belong in APR.
> Oh - thanks for picking me up on that. In that case it doesn't look
> like an issue that needs to be marked for future attention, so may I
> just delete that pair of comments entirely?

I don't mind if you do. I left the comments in for historical reasons,
but since we're a version control system, history can take care of
itself. :-)

Brane Čibej   <brane_at_xbc.nu>   http://www.xbc.nu/brane/
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Received on Mon Dec 8 20:07:00 2003

This is an archived mail posted to the Subversion Dev mailing list.

This site is subject to the Apache Privacy Policy and the Apache Public Forum Archive Policy.