Branko Čibej wrote:
> Julian Foad wrote:
>
>>Does this look right?
>
> Yes, but...
Thanks. Committed in r7960 ...
>>-/* ### todo: This function doesn't really belong in this header, but
>>- it didn't seem worthwhile to create a new header just for one
>>- function, especially since this should probably move to APR as
>>- apr_cmdline_init() or whatever anyway. There's nothing
>>- svn-specific in its code, other than SVN_WIN32, which obviously APR
>>- has its own way of dealing with. Thoughts? (Brane?) */
>>-/* ### Well, it's not one function any more, so it now has its own
>>- header. Besides, everything here is svn-specific. --brane */
>>+/* ### todo: This function should perhaps move to APR as
>>+ apr_cmdline_init() or whatever. */
>
> ...this bit does not. The point of my reply to Karl's comment was that
> this initializatino does _not_ belong in APR.
... without that comment.
- Julian
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Received on Mon Dec 8 22:08:43 2003