[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: Oh, the horror of monstrously broken tests...

From: Branko Čibej <brane_at_xbc.nu>
Date: 2003-11-19 20:19:58 CET

C. Michael Pilato wrote:

>Branko Čibej <brane@xbc.nu> writes:
>
>
>
>>I just noticed something fairly horrible. In many places in our test
>>suite, we don't check the stderr output from 'svn', which means that
>>failed tests aren't always detected. For example, all the autoprop tests
>>fail on Windows (because someone used os.path.join to construct a
>>URL...pelople never learn), but only three were tagged as failed.
>>
>>This is serious. The easiest solution would be for
>>svntest.main.run_command to raise an exception if the stderr output
>>isn't empty when no error is expected.
>>
>>Other suggestions welcome.
>>
>>
>
>I have only one suggestion -- *please* fix this now, if you have time,
>and in whatever way you see fit.
>
Done in r7808.

-- 
Brane Čibej   <brane_at_xbc.nu>   http://www.xbc.nu/brane/
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Received on Wed Nov 19 20:19:02 2003

This is an archived mail posted to the Subversion Dev mailing list.