Re: svn commit: rev 7609 - in trunk/subversion: clients/cmdline include libsvn_client libsvn_subr

Philip Martin <philip@codematters.co.uk> writes:

> Is this really the implementation used in APR? It's not thread safe,
> it could return a path that is totally invalid if one thread copies
> the global cached path while another thread is writing into the cache.

Yeah, Sander's already gotten a couple of responses along this line.
The idea of having a global cache was in my original proposal, but I
never figured out how to do it safely. Now, I feel like the cache
should be tossed out, for the thread-safety issue already mentioned,
but also because the library can be long-lived (think Subversion GUI),
and changes to things like a user's %TEMP% environment variable should
be immediately reflected the in temp-directory search algorithm.

> On the Subversion front svn_io_temp_dir should return a path that has
> been svn_path_canonicalized, at present using TEMPDIR="." or
> TEMPDIR="/home/philip/" fails.

Ooh! That another interesting data point. Thanks, Philip.

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Received on Mon Nov 3 16:18:06 2003