[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: svn commit: rev 7609 - in trunk/subversion: clients/cmdline include libsvn_client libsvn_subr

From: Philip Martin <philip_at_codematters.co.uk>
Date: 2003-11-03 16:08:45 CET

striker@tigris.org writes:

> Author: striker
> Date: Sun Nov 2 15:19:37 2003
> New Revision: 7609
> Modified:
> trunk/subversion/clients/cmdline/propedit-cmd.c
> trunk/subversion/clients/cmdline/util.c
> trunk/subversion/include/svn_io.h
> trunk/subversion/libsvn_client/blame.c
> trunk/subversion/libsvn_client/cat.c
> trunk/subversion/libsvn_client/ra.c
> trunk/subversion/libsvn_client/repos_diff.c
> trunk/subversion/libsvn_subr/io.c
> Log:
> Fix a large chunk of issue #929.
> * subversion/include/svn_io.h
> (svn_io_temp_dir): New. Temporary duplicate the implementation
> that is in APR, since APR 0.9.5 has a broken apr_temp_dir_get().

Is this really the implementation used in APR? It's not thread safe,
it could return a path that is totally invalid if one thread copies
the global cached path while another thread is writing into the cache.

On the Subversion front svn_io_temp_dir should return a path that has
been svn_path_canonicalized, at present using TEMPDIR="." or
TEMPDIR="/home/philip/" fails.

Philip Martin
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Received on Mon Nov 3 16:12:32 2003

This is an archived mail posted to the Subversion Dev mailing list.

This site is subject to the Apache Privacy Policy and the Apache Public Forum Archive Policy.