[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

RE: svn commit: rev 7609 - in trunk/subversion: clients/cmdline include libsvn_client libsvn_subr

From: Sander Striker <striker_at_apache.org>
Date: 2003-11-03 16:15:39 CET

> From: Philip Martin [mailto:philip@codematters.co.uk]
> Sent: Monday, November 03, 2003 4:09 PM

> > (svn_io_temp_dir): New. Temporary duplicate the implementation
> > that is in APR, since APR 0.9.5 has a broken apr_temp_dir_get().
>
> Is this really the implementation used in APR? It's not thread safe,
> it could return a path that is totally invalid if one thread copies
> the global cached path while another thread is writing into the cache.

Correct. This needs a fix, quite possibly by not caching.
 
> On the Subversion front svn_io_temp_dir should return a path that has
> been svn_path_canonicalized, at present using TEMPDIR="." or
> TEMPDIR="/home/philip/" fails.

Ah, right. Thanks.

Sander

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Received on Mon Nov 3 16:16:23 2003

This is an archived mail posted to the Subversion Dev mailing list.