[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: [PATCH] python 2.1 support (build/generator/gen_base.py)

From: Martin Furter <mf_at_rola.ch>
Date: 2003-10-05 23:00:57 CEST

On 5 Oct 2003, C. Michael Pilato wrote:

> This patch looks semantically fine, but (and I really shouldn't have
> to point out stuff like this -- I mean, doesn't everyone take some
> degree of pride in making their code *look* good?) this module doesn't
> use the "foo( param )" coding style. It uses "foo(param)".

mf: ERROR: too many coding styles ;-)
I'm sorry, didn't see that.

So here's the patch again:

Index: build/generator/gen_base.py
--- build/generator/gen_base.py (revision 7308)
+++ build/generator/gen_base.py (working copy)
@@ -95,7 +95,7 @@
     """Return a list of section objects from a string of section
     sections = [ ]
     for section_name in string.split(section_list):
- if section_name not in self.skip_sections:
+ if not self.skip_sections.has_key(section_name):
     return sections

and the missing log message:

Solve the python 2.1 incompatibility introduced in rev 7295.

* build/generator/gen_base.py
    use 'x.has_key(y)' instead of 'y in x'


To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Received on Sun Oct 5 23:02:27 2003

This is an archived mail posted to the Subversion Dev mailing list.

This site is subject to the Apache Privacy Policy and the Apache Public Forum Archive Policy.