Martin Furter <mf@rola.ch> writes:
> Today i wanted to update svn and got an error in
> build/generator/gen_base.py:
> TypeError: 'in' or 'not in' needs sequence right argument
> ERROR: gen-make.py failed
>
> Here's a patch:
>
> Index: build/generator/gen_base.py
> ===================================================================
> --- build/generator/gen_base.py (revision 7308)
> +++ build/generator/gen_base.py (working copy)
> @@ -95,7 +95,7 @@
> """Return a list of section objects from a string of section
> names."""
> sections = [ ]
> for section_name in string.split(section_list):
> - if section_name not in self.skip_sections:
> + if not self.skip_sections.has_key( section_name ):
> sections.append(self.sections[section_name])
> return sections
This patch looks semantically fine, but (and I really shouldn't have
to point out stuff like this -- I mean, doesn't everyone take some
degree of pride in making their code *look* good?) this module doesn't
use the "foo( param )" coding style. It uses "foo(param)".
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Received on Sun Oct 5 22:36:24 2003