Re: "svn commit" should always prompt after popping up a log message editor

Philip Martin <philip@codematters.co.uk> writes:

> kfogel@collab.net writes:
>
>> When the log message is left empty, then svn would prompt
>>
>> "Empty log message -- c)ontinue, a)bort, ...?"
>>
>> And, in the log message template, the one that says everything
>> following this line is ignored blah blah blah, we can have a note
>> telling the user to that saving an empty log message will cause svn to
>> prompt before committing.
>
> Yuck! No more prompts! I like the current behaviour.

I'm revising my opinion of this idea. I accept the arguments that the
current methods of aborting a commit, killing the editor or deleting
the message file, are not particularly convenient.

If I were to implement it I would do it slightly differently. Rather
than check for an empty file I would wait until the suffix list of
paths has been stripped, and then check the remaining log message for
non-whitespace characters. An empty, or purely whitespace, log
message would cause the abort/continue/edit prompt. The existing file
size/timestamp check and prompt would then be redundant and could be
removed.

-- 
Philip Martin
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org