Re: "svn commit" should always prompt after popping up a log message editor

kfogel@collab.net wrote:
> David Summers <david@summersoft.fay.ar.us> writes:
>
>>That's the part that always gets me. My fingers are trained to save often
>>and it is proving very difficult to break them of that habit. When it is
>>saved then the commit goes on through....I've had quite a few
>>unintentional commits because of that. :-(
>
> No, it's when the editor process exits without error, not when the
> file is saved. (You can save it N times, but you only exit once.)

I think he meant that, because he has already saved, even if he then quits "without saving", Subversion takes the file that was saved earlier and commits with it.

Or are you using an editor that returns an error if you quit without saving? That would explain your view of the matter, because then it would make it easy for you to abort the commit. I don't think many editors do that.

>>Maybe if it could re-ask when the editor is exited? (Or has this already

"Re-ask"? It (Subversion) hasn't asked anything at all at this stage, has it?

>>been discussed?)
>
> If you haven't realized by the end of your log message that you don't
> want to commit, I'm not sure that adding Yet Another Confirmation
> Moment is going to do a lot of good. Your fingers will quickly
> habituate to answering 'y' to that too, and you'll be right back where
> you started.

It's not that I haven't realised that I don't want to commit. I have realised, and now want to abort the commit while preserving my mostly-finished log message. At this point I stop and think "Ah, how do I get out of here? Oh yes, when I quit, I'll get asked that question that I normally answer without thinking. But this time I'll think before answering it. OK ... now quit the editor ... now answer Subversion's confirmation, this time in the negative."

- Julian

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Received on Fri Sep 26 02:53:57 2003