Re: "svn commit" should always prompt after popping up a log message editor

kfogel@collab.net wrote:
>
> We're confusing two unrelated features in this thread:
>
> 1. The ability to edit the list of files in the commit group in the
> log message, so as to change what gets committed.

This is not highly relevant to the thread, but I think it got mentioned as a possible way to satisfy my desire to abort the commit without losing my log message, in that I could delete the list of files and then save and exit. But it doesn't solve my main point, which is that it is too easy to accidentally save and exit.

> 2. The ability to cancel the commit from $SVN_EDITOR, because one
> realizes while writing the log message that one isn't ready to
> commmit.
...
> (2) is easy -- just exit your editor without saving, or with error,
> and Subversion should prompt you to c)ontinue, a)bort, etc.

Exit without saving: not possible if I have already saved, which is quite likely as I often save my work from time to time while writing it.

Exit with error: difficult for most "ordinary" people with many editors. Executing a "ps" and a "kill" in another shell is not user-friendly enough for this common task.

(Exit with an empty file: generally easy, but often you want to keep your mostly-written log message to use later, so this is not a friendly option.)

- Julian

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Received on Fri Sep 26 02:58:08 2003