Re: "svn commit" should always prompt after popping up a log message editor

Philip Martin wrote:
> Julian Foad <julianfoad@btopenworld.com> writes:
>
>>To these ends, I suggest that Subversion should always prompt after
>>the editor exits. Perhaps it changes the wording of the prompt, or
>>the default response, depending on the content of the log message,
>>but it should always give the choice of proceeding or aborting.
>>
>>Thoughts?
>
> At present it is possible to set SVN_EDITOR to run a command that
> automatically generates log messages thus making 'svn commit'
> non-interactive. Your suggestion would mean it is no longer possible
> to do this. Yes, there are other way to achieve a non-interactive
> commit, but I like the current system.

That's an interesting usage that I hadn't thought of. It's fair enough that you should like it, but I don't believe that the ability to do this was intentionally provided, and I don't think it buys you anything over "svn-commit blah..." where "svn-commit" is a simple script that generates your log message and passes it to "svn commit -F".

> (I do set my SVN_EDITOR like this, although I don't use its log
> messages for the commits I make to the Subversion repository.)

Unless you accidentally leave out the "-F" or "-m" from a commit command!

And if you run "svn propedit svn:ignore .", your ignores list gets instantly turned into a log message?

I'm sorry, but I'd have to call this a "mis-use" of SVN_EDITOR.

- Julian

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Received on Fri Sep 26 02:48:43 2003