[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: "svn commit" should always prompt after popping up a log message editor

From: Marc Haisenko <haisenko_at_webport.de>
Date: 2003-09-25 14:35:00 CEST

On Thursday 25 September 2003 13:40, Julian Foad wrote:
> PREAMBLE:
>
> I don't like Subversion to pop up an editor inside a "commit" command. At
> least not by default. It feels wrong to do an arbitrary amount of work
> (writing, diffing, perhaps editing and re-compiling and testing) inside a
> command that is conceptually atomic. Yes, it depends on whether you feel
> you are "inside" the commit, but I do feel like that.
>
> Usually when I start to write the log message, I realise that something is
> not quite right and need to go back and fix it. You can't safely and
> easily do this from within "svn commit". That is, you can save your
> mostly-written log message in a different file, then delete the content of
> the original log message file, exit from the editor and have Subversion
> prompt you whether to continue the commit. But are you sure that your
> editor's idea of "empty" matches Subversion's idea of "empty" (some editors
> insist on leaving an end-of-line in the file)? What is the chance that you
> start editing some other files, then save-and-exit from the editor,
> forgetting that you were editing the log message? Too many chances to
> accidentally commit the wrong thing.

Just some thoughts...

There once was the proposal that you should be able to delete lines from the
listing of modified files/properties, and svn should then ignore (i.e. not
commit) those files/properties that were deleted from that list. This would
propably solve your problem, I guess, since you'd do it this way:

svn commit
Inside the editor, you realize that file abc/xyz is not ready for commit yet.
You type in your comment for the remaining files and delete abc/xyz from the
list of files to be commit. Then save and exit the editor, and everything
except abc/xyz gets committed.

One could also implement a kind of command-parsing, like when the comment file
starts with ":svn-delay\n" the commit is aborted and the comment is saved so
that on your next commit the comment without the ":svn-delay\n" is recovered.

C'ya,
        Marc

-- 
Marc Haisenko
Systemspezialist
Webport IT-Services GmbH
mailto: haisenko@webport.de
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Received on Thu Sep 25 14:36:17 2003

This is an archived mail posted to the Subversion Dev mailing list.

This site is subject to the Apache Privacy Policy and the Apache Public Forum Archive Policy.