Re: [PATCH] Add bdb path option to gen-make for windows

Branko Čibej wrote:
> Chris Foote wrote:
>
> > This patch allows the bdb headers and libs to be shared by multiple
> > working copies on windows.
> >
[snip]
>
> Looks fine, except ...
>
> > @@ -213,7 +222,10 @@
> >
> > result = [ ]
> > for item in list:
> > - result.append(rootpath + '\\' + item)
> > + if os.path.isabs(item):
> > + result.append(item)
> > + else:
> > + result.append(rootpath + '\\' + item)
> > return result
>
> I suspect slashes could creep into the absolute path here.
>
I don't see how?

If the item path is absolute then it is just added to the result, and if it
is
relative then it is assumed to be a path from the rootpath.

Chris

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Received on Wed Sep 24 23:11:09 2003