Re: [PATCH] Add bdb path option to gen-make for windows

Chris Foote wrote:

> This patch allows the bdb headers and libs to be shared by multiple
> working copies on windows.
>
> Chris
>
> Log:
> Add a windows specific option to gen-make so that the user can specify
> a path to the Berkely DB headers and libs.
>
> * gen-make.py:
> (_usage_exit): Add --with-berkely-db option.
> (__main__): ditto.
>
> * build/generator/gen_win.py:
> (parse_options): Add --with-berkely-db option.
> (__init__): Search for libdb4? in the specified dir and then
> the default dirs.
> (map_rootpath): If the path is absolute then use it, else
> prepend the root path.

Looks fine, except ...

> @@ -213,7 +222,10 @@
>
> result = [ ]
> for item in list:
> - result.append(rootpath + '\\' + item)
> + if os.path.isabs(item):
> + result.append(item)
> + else:
> + result.append(rootpath + '\\' + item)
> return result

I suspect slashes could creep into the absolute path here.

-- 
Brane Čibej   <brane_at_xbc.nu>   http://www.xbc.nu/brane/
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org