Re: [PATCH] Add bdb path option to gen-make for windows

Branko ÄŒibej wrote:
> Chris Foote wrote:
>
>> This patch allows the bdb headers and libs to be shared by multiple
>> working copies on windows.
> ...
>> Log:
>> Add a windows specific option to gen-make so that the user can
>> specify a path to the Berkely DB headers and libs.
> ...
> Looks fine, except ...
>
>> @@ -213,7 +222,10 @@
>>
>> result = [ ]
>> for item in list:
>> - result.append(rootpath + '\\' + item)
>> + if os.path.isabs(item):
>> + result.append(item)
>> + else:
>> + result.append(rootpath + '\\' + item)
>> return result
>
> I suspect slashes could creep into the absolute path here.

Doesn't this code only add slashes to relative paths?

- Russ

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Received on Wed Sep 24 22:48:19 2003