Julian Foad <julianfoad@btopenworld.com> writes:
> Joel Rosdahl wrote:
>
> > * Made use of parentheses, quotes and commas consistent (using
> > "logical quoting"):
>
> Logical quoting is already used throughout most of the book, so it
> is right to make it consistently logical. But several of the
> instances that you have changed are of this basic form:
>
> Sentence (sentence).
>
> which is grammatically poor.
Agreed. Unfortunately, those are much harder to find with regexps. :-)
Some other time, maybe.
> Some of them would be better in one of these forms:
>
> Sentence. (Sentence.)
> Sentence (with additional clause).
Or sometimes one of these:
Sentence; sentence.
Sentence—sentence.
> > Index: doc/book/book/ch07.xml
> > ===================================================================
> > - <!-- Fitz's revised graphic here (Heaven help us if he ever makes
> > + <!-- Fitz's revised graphic here (heaven help us if he ever makes
> > another piece of graphic art ... what *will* we call it?).
>
> It's not worth changing that file just for a capitalisation in an
> XML comment. (It it were a capitalisation in the output text, that
> would be different. If there were other changes in the file, then
> maybe.) And some people intentionally capitalise "Heaven",
> considering it to be a "proper noun".
Fair enough.
> > Index: doc/book/book/glossary.xml
> > ===================================================================
> > - <para> A <command>svn</command> command that is used to add a
> > + <para> An <command>svn</command> command that is used to add a
>
> There is no point in changing that one unless you make the other
> instances of "a svn" and "an svn" consistent as well. The trouble
> is, some people (like you and I) pronounce "svn" as "ess vee enn"
> while others pronounce it "subversion" or "seven" or some such.
> There are several uses of "a" and several "an" in the book: try
Ah, yes, that was a bit sloppy of me.
> If you want to revise some of the "Sentence (sentence)" structures
> and/or change all instances of "a svn" to "an svn" in the next few
> days, that would be great. If not, I will commit all of your
> changes apart from ch07.xml and glossary.xml.
Sure. Revised patch attached.
Log message entry:
======================================================================
Various minor grammar and typographical changes to the Subversion
book:
* Made use of parentheses, quotes and commas consistent (using
"logical quoting"):
Like this: Not like this:
----------------------------------------
Foo (fie fum). Foo (fie fum.)
Foo "fie fum". Foo "fie fum."
Foo (fie), fum. Foo (fie,) fum.
Foo "fie", fum. Foo "fie," fum.
(Foo fie fum.) (Foo fie fum).
Foo (fie fum). Foo (Fie fum).
* Added a missing space after a </quote>.
* Corrected name of the extra files created when a merge conflict has
been detected.
* Removed some left-over closing parentheses.
* Use "an svn [...]" instead of "a svn [...]".
* Some other minor grammar fixes.
======================================================================
--
Joel Rosdahl <joel@rosdahl.net> (GnuPG/PGP key available)
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Received on Mon Sep 1 20:15:02 2003