Re: [PATCH] svnadmin lsdblogs, fs.c, Windows

Russell Yanofsky wrote:

> Martin Hauner wrote:
>
>>Russell Yanofsky wrote:
>>
>>
>>>>+ SVN_BDB_ERR (env->set_alloc (env,malloc,realloc,free));
>>>>...
>>>>- free (filelist);
>>>>+ env->db_free (filelist);
>>>
>>>
>>>Why add a call to set_alloc AND switch from free to db_free? Either
>>>change should be sufficient by itself.
>>
>>Sure, but I think env->db_free() better communicates that filelist
>>came from db.
>
>
> I think so too. But if you use it can't you get rid of the set_alloc call?

Ah, now I see what you were talking about in your first reply. :)
The problem here is that db_env_create doesn't set the memory stuff
itself. So without set_alloc db_free is NULL.

-- 
Martin
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org