Martin Hauner <hauner@web.de> writes:
> Hi all,
>
> here is a small fix for a memory problem in svn_fs_berkeley_logfiles.
> It gets called when you run svnadmin lsdblogs.
>
> attached is an 'in place fix'...
>
> --
> Martin
> * subversion/libsvn_fs/fs.c
> (svn_fs_berkeley_logfiles): fixed memory alloc/free of filelist on
> windows.
What's the status of this patch? Russell seems to think that we don't
need both the set_alloc and db_free. I'm confused as to why we need
either -- I mean, why is this failing for log file listings, but not
for the dozens of other places in the code (names, all the uses of
DBT's with the DB_DBT_MALLOC flag) where this same type of memory
transfer is happening? Everything else just uses DB_ENV->set_alloc()
and free(). In fact, I can't even seem to find documentation for
DB_ENV->db_free() on Sleepycat's website!
I'll commit up the set_alloc portion of the change so that this code
will be consistent with the rest of the Subversion code that uses
Berkeley environments.
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Received on Mon Aug 25 09:02:48 2003