[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: [PATCH] svnadmin lsdblogs, fs.c, Windows

From: Russell Yanofsky <rey4_at_columbia.edu>
Date: 2003-08-22 16:06:55 CEST

Martin Hauner wrote:
> Russell Yanofsky wrote:
>
>>> + SVN_BDB_ERR (env->set_alloc (env,malloc,realloc,free));
>>> ...
>>> - free (filelist);
>>> + env->db_free (filelist);
>>
>>
>> Why add a call to set_alloc AND switch from free to db_free? Either
>> change should be sufficient by itself.
>
> Sure, but I think env->db_free() better communicates that filelist
> came from db.

I think so too. But if you use it can't you get rid of the set_alloc call?

- Russ

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Received on Fri Aug 22 19:19:31 2003

This is an archived mail posted to the Subversion Dev mailing list.

This site is subject to the Apache Privacy Policy and the Apache Public Forum Archive Policy.