[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: Patch for tweak-log.cgi to support multiple repositories

From: John Szakmeister <john_at_szakmeister.net>
Date: 2003-08-15 02:10:08 CEST

On Wednesday 13 August 2003 10:02, cmpilato@collab.net wrote:
> John Szakmeister <john@szakmeister.net> writes:
> > On Wednesday 13 August 2003 01:52, kfogel@collab.net wrote:
> > > "Sander Striker" <striker@apache.org> writes:
> > > > Hmmm, I remember doing that once and it didn't end up going as
> > > > I had planned. May very well have been a user issue...
> > >
> > > It was a security issue, I believe. We felt (surprise!) that
> > > specifying the repos as a CGI parameter might have some security
> > > implications :-).
> >
> > I could definitely see that being a problem. Fortunately, we run in a
> > sandbox... we have our own internal development network that is
> > disconnected from every other network so this isn't a problem for us. :-)
>
> Poo. Make tweak-log.cgi understand the PATH_INFO portion of a CGI
> request, and let it validate that PATH_INFO as a Subversion repository
> before going any further. Or, you could give tweak-log a
> configuration file which lists repositories, like ViewCVS has.

If I knew more about CGI, I might make an attempt at that. Unfortunately, I'm
not a web guy. :-( Perhaps I'll pick up a book and take a look at it though.
The only reason I did this was to have just one script, and because we
internally generate a webpage that list the active repositories. It was
easier to generate a CGI parameter than update an active list of
repositories.

> > Perhaps changing the script to use the command line client instead
> > of svnlook would be a better way to go?
>
> Bad plan. This will quite complicate an existing, simple code path
> for making these kinds of changes, for absolutely no gain.

Yeah, I guess for some reason I thought it would propagate authentication back
to the end user... that's what I get for trying to think at 3:40 in the
morning.

> > Or making sure the tweak log link is behind some sort of
> > authentication might be a smarter thing to do.
>
> We keep tweak-log on svn.collab.net behind <Limit> configuration tags,
> and it uses the same AuthUserFile that the repository does.

Now that's a good idea.

-John

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Received on Fri Aug 15 02:09:06 2003

This is an archived mail posted to the Subversion Dev mailing list.

This site is subject to the Apache Privacy Policy and the Apache Public Forum Archive Policy.