[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: Patch for tweak-log.cgi to support multiple repositories

From: <cmpilato_at_collab.net>
Date: 2003-08-13 16:02:15 CEST

John Szakmeister <john@szakmeister.net> writes:

> On Wednesday 13 August 2003 01:52, kfogel@collab.net wrote:
> > "Sander Striker" <striker@apache.org> writes:
> > > Hmmm, I remember doing that once and it didn't end up going as
> > > I had planned. May very well have been a user issue...
> >
> > It was a security issue, I believe. We felt (surprise!) that
> > specifying the repos as a CGI parameter might have some security
> > implications :-).
>
> I could definitely see that being a problem. Fortunately, we run in a
> sandbox... we have our own internal development network that is disconnected
> from every other network so this isn't a problem for us. :-)

Poo. Make tweak-log.cgi understand the PATH_INFO portion of a CGI
request, and let it validate that PATH_INFO as a Subversion repository
before going any further. Or, you could give tweak-log a
configuration file which lists repositories, like ViewCVS has.

> Perhaps changing the script to use the command line client instead
> of svnlook would be a better way to go?

Bad plan. This will quite complicate an existing, simple code path
for making these kinds of changes, for absolutely no gain.

> Or making sure the tweak log link is behind some sort of
> authentication might be a smarter thing to do.

We keep tweak-log on svn.collab.net behind <Limit> configuration tags,
and it uses the same AuthUserFile that the repository does.

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Received on Fri Aug 22 04:19:08 2003

This is an archived mail posted to the Subversion Dev mailing list.

This site is subject to the Apache Privacy Policy and the Apache Public Forum Archive Policy.